Hi Hans, On Fri, 2017-12-15 at 15:22 +0100, Hans Verkuil wrote: > Hi Philipp, > > On 13/12/17 15:09, Philipp Zabel wrote: > > Add support for the CodaHx4 VPU used on i.MX51. > > > > Decoding h.264, MPEG-4, and MPEG-2 video works, as well as encoding > > h.264. MPEG-4 encoding is not enabled, it currently produces visual > > artifacts. > > > > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > --- > > drivers/media/platform/coda/coda-bit.c | 45 ++++++++++++++++++++++--------- > > drivers/media/platform/coda/coda-common.c | 44 +++++++++++++++++++++++++++--- > > drivers/media/platform/coda/coda.h | 1 + > > 3 files changed, 74 insertions(+), 16 deletions(-) > > > > <snip> > > > + [CODA_IMX51] = { > > + .firmware = { > > + "vpu_fw_imx51.bin", > > + "vpu/vpu_fw_imx51.bin", > > + "v4l-codahx4-imx51.bin" > > + }, > > + .product = CODA_HX4, > > + .codecs = codahx4_codecs, > > + .num_codecs = ARRAY_SIZE(codahx4_codecs), > > + .vdevs = codahx4_video_devices, > > + .num_vdevs = ARRAY_SIZE(codahx4_video_devices), > > + .workbuf_size = 128 * 1024, > > + .tempbuf_size = 304 * 1024, > > + .iram_size = 0x14000, > > + }, > > What's the status of the firmware? Is it going to be available in some firmware > repository? I remember when testing other imx devices that it was a bit tricky > to get hold of the firmware. And googling v4l-codahx4-imx51.bin doesn't find > anything other than this patch. As far as I am aware, so far all efforts to get these firmware binaries relicensed in a way that makes them redistributable in linux-firmware have not succeeded. They are distributed by NXP directly in the firmware-imx package. The http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-arm/ repository contains links to the latest version: wget http://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-5.4.bin dd if=firmware-imx-5.4.bin bs=34087 skip=1 | tar xj cat firmware-imx-5.4/COPYING regards Philipp