Em Thu, 14 Dec 2017 09:59:32 +0000 "Takiguchi, Yasunari" <Yasunari.Takiguchi@xxxxxxxx> escreveu: > Dear Mauro > > Thanks for your review. > > We will refer to your comments and consider how to respond for them. > I want to confirm one thing about SPDX license text > > We will add SPDX license text to our files, > Is it necessary to add SPDX not only .c .h Makefile but also Kconfig? > When I checked current files in driver/media, there is no Kconfig file which has SPDX. SPDX is a new requirement that started late on Kernel 4.14 development cycle (and whose initial changes were merged directly at Linus tree). Not all existing files have it yet, as identifying the right license on existing files is a complex task, but if you do a: $ git grep SPDX $(find . -name Makefile) $(find . -name Kconfig) You'll see that lot of such files have it already. So, yes, please add it to both Makefile and Kconfig. Thanks, Mauro
