Hi Mauro,
Am Montag, den 23.11.2009, 14:04 -0200 schrieb Mauro Carvalho Chehab:
> Hi Lukáš/Hermann,
>
> Any news about this patch? I'll mark it as RFC at the patchwork, since it seems that this is not finished yet. Please let me know if you make some progress.
>
> > @@ -1352,6 +1353,7 @@ struct saa7134_board saa7134_boards[] =
> > .tuner_addr = ADDR_UNSET,
> > .radio_addr = ADDR_UNSET,
> > .mpeg = SAA7134_MPEG_DVB,
> > + .num_frontends = 1,
> > .inputs = {{
> > .name = name_tv,
> > .vmux = 1,
>
> Just one suggestion here: it is a way better to assume that an "uninitialized" value (e. g. num_frontends = 0) for num_frontends to mean that just one frontend exists. This saves space at the initialization segment
> of the module and avoids the risk of someone forget to add num_frontends=0.
>
> cheers,
> Mauro.
I currently don't have time to work on it and Lukáš' time is also
limited.
We stay in contact and I can provide a device not yet working for me to
him, if he wants. I'll keep you posted. You can have one too ;)
Currently the hardware reset in saa7134-dvb.c seems to break tda8275a
hybrid tuners on my saa7131e devices for DVB-T. This is not restricted
to the devices with multiple frontends, but also hits such with single
frontend only. The TRIO has two tda8275a, they are not in use as hybrid
tuners and don't need extra initialization again, that might be the
difference.
We should avoid such saa7133 hardware reset on those cards not needing
it in any case, means all with single frontend.
ON DVB-S is also a regression visible, in one of two cases needs a
second tuning attempt now and it also seems to be related to the
hardware reset, since without works fine like previously.
Patch is not ready yet for inclusion.
Cheers,
Hermann
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
