Dear Guennadi
> > -#define HSP_LOW 0x00 /* 0 : HS pin output polarity is active low */
> > +#define HSP_LO 0x00 /* 0 : HS pin output polarity is active low */
>
> I would remove field names with "0" values completely. Also see below
(snip)
> > +#define VSP_V_LO VSP_HI /* xSSL_xVALID case, polarity will be inverted */
> > +#define VSP_V_HI VSP_LO
> > +#define HSP_V_LO HSP_HI
> > +#define HSP_V_HI HSP_LO
>
> I wouldn't add these - just add a comment below and use reverted
> [HV]SP_{HI,LO} macros.
Hmm OK.
> + /*
> + * We use VVALID and DVALID signals to control VSYNC and HSYNC
> + * outputs, in this mode their polarity is inverted.
> + */
> + if (flags & SOCAM_HSYNC_ACTIVE_LOW)
> + val |= HSP_HI;
>
> without any else, agree?
agree.
OK I will modify it.
Best regards
--
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
