Hi Jacopo, Thank you for the patch. On Wednesday, 15 November 2017 12:56:02 EET Jacopo Mondi wrote: > Copy the soc_camera based driver in v4l2 sensor driver directory. > This commit just copies the original file without modifying it. As for patch 07/10, you might want to explain why you're not patching the Kconfig and Makefile here, that is because you will first convert the driver away from soc-camera in the next commit. Apart from that, Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > --- > drivers/media/i2c/tw9910.c | 999 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 999 insertions(+) > create mode 100644 drivers/media/i2c/tw9910.c -- Regards, Laurent Pinchart