On Wed, Dec 06, 2017 at 02:58:39PM +0000, Kieran Bingham wrote: > From: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > > Devices supporting multiple endpoints on a single device node must set > their subdevice fwnode to the endpoint to allow distinct comparisons. > > Adapt the match_fwnode call to compare against the provided fwnodes > first, but to also perform a cross reference comparison against the > parent fwnodes of each other. > > This allows notifiers to pass the endpoint for comparison and still > support existing subdevices which store their default parent device > node. > > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > --- > > Hi Sakari, > > Since you signed-off on this patch - it has had to be reworked due to the > changes on the of_node_full_name() functionality. > > I believe it is correct now to *just* do the pointer matching, as that matches > the current implementation, and converting to device_nodes will be just as > equal as the fwnodes, as they are simply containers. > > Let me know if you are happy to maintain your SOB on this patch - and if we need > to work towards getting this integrated upstream, especially in light of your new > endpoint matching work. I'd really want to avoid resorting to matching opportunistically --- please see my reply to Niklas on "[RFC 1/1] v4l: async: Use endpoint node, not device node, for fwnode match". -- Regards, Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
