On Fri, Dec 01, 2017 at 05:19:37PM +0000, Jeremy Sowden wrote:
> -#define DEFAULT_PIPE_INFO \
> -{ \
> - {IA_CSS_BINARY_DEFAULT_FRAME_INFO}, /* output_info */ \
> - {IA_CSS_BINARY_DEFAULT_FRAME_INFO}, /* vf_output_info */ \
> - IA_CSS_BINARY_DEFAULT_FRAME_INFO, /* raw_output_info */ \
> - { 0, 0}, /* output system in res */ \
> - DEFAULT_SHADING_INFO, /* shading_info */ \
> - DEFAULT_GRID_INFO, /* grid_info */ \
> - 0 /* num_invalid_frames */ \
> -}
> +#define DEFAULT_PIPE_INFO ( \
Why does this have a ( now? That can't compile can it??
> + (struct ia_css_pipe_info) { \
> + .output_info = {IA_CSS_BINARY_DEFAULT_FRAME_INFO}, \
> + .vf_output_info = {IA_CSS_BINARY_DEFAULT_FRAME_INFO}, \
> + .raw_output_info = IA_CSS_BINARY_DEFAULT_FRAME_INFO, \
> + .output_system_in_res_info = { 0, 0 }, \
> + .shading_info = DEFAULT_SHADING_INFO, \
> + .grid_info = DEFAULT_GRID_INFO, \
> + .num_invalid_frames = 0 \
> + } \
> +)
We need to get better compile test coverage on this... :/ There are
some others as well.
regards,
dan carpenter
