Re: [PATCH 1/3] media: atomisp: convert default struct values to use compound-literals with designated initializers.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2017-12-01, at 18:07:25 +0300, Dan Carpenter wrote:
> I can't apply this (to today's linux-next) but does this really work:
>
> > +(struct ia_css_3a_grid_info) { \
> > +	.ae_enable		= 0, \
> > +	.ae_grd_info		= (struct ae_public_config_grid_config) { \
> > +					width = 0, \
> > +					height = 0, \
> > +					b_width = 0, \
> > +					b_height = 0, \
> > +					x_start = 0, \
> > +					y_start = 0, \
> > +					x_end = 0, \
> > +					y_end = 0 \
>
> I'm pretty sure those lines should start with a period.
>
> - 					width = 0, \
> +					.width = 0, \

Indeed they should.  A second version is in the pipeline.

J.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux