Thanks Sakari for review, On 11/24/2017 03:06 PM, Sakari Ailus wrote: > Hi Hugues, > > On Thu, Nov 16, 2017 at 02:41:41PM +0100, Hugues Fruchet wrote: >> @@ -2185,7 +2262,11 @@ static int ov5640_s_stream(struct v4l2_subdev *sd, int enable) >> goto out; >> } >> >> - ret = ov5640_set_stream(sensor, enable); >> + if (sensor->ep.bus_type == V4L2_MBUS_CSI2) >> + ret = ov5640_set_stream_mipi(sensor, enable); >> + else >> + ret = ov5640_set_stream_dvp(sensor); > > Hmm. Do you want to configure it even when you're disabling streaming? > I will fix this by only setting stream when enabling streaming. Best regards, Hugues.