Hi Sean, On Fri, Nov 24, 2017 at 11:43:58AM +0000, Sean Young wrote: > Due to the slowness of the CEC bus, autorepeat handling rather special > on CEC. If the repeated user control pressed message is received, a > keydown repeat should be sent immediately. This sounds like you want to have hardware autorepeat combined with software one. This seems fairly specific to CEC and I do not think that this should be in input core; but stay in the driver. Another option just to decide what common delay for CEC autorepeat is and rely on the standard autorepeat handling. The benefit is that users can control the delay before autorepeat kicks in. > > By handling this in the input layer, we can remove some ugly code from > cec, which also sends a keyup event after the first keydown, to prevent > autorepeat. If driver does not want input core to handle autorepeat (but handle autorepeat by themselves) they should indicate it by setting appropriate dev->rep[REP_DELAY] and dev->rep[REP_PERIOD] before calling input_register_device(). This will let input core know that it should not setup its autorepeat timer. Thanks. -- Dmitry
