Hi Akinobu, Thankyou for the patch. On 24/11/17 14:40, Akinobu Mita wrote: > The sub-device for ov7670 is registered by v4l2_async_register_subdev(). > So it should be unregistered by v4l2_async_unregister_subdev() instead of > v4l2_device_unregister_subdev(). > > Cc: Jonathan Corbet <corbet@xxxxxxx> > Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> > Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx> > --- > drivers/media/i2c/ov7670.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c > index 950a0ac..b61d88e 100644 > --- a/drivers/media/i2c/ov7670.c > +++ b/drivers/media/i2c/ov7670.c > @@ -1820,7 +1820,7 @@ static int ov7670_remove(struct i2c_client *client) > struct v4l2_subdev *sd = i2c_get_clientdata(client); > struct ov7670_info *info = to_state(sd); > > - v4l2_device_unregister_subdev(sd); > + v4l2_async_unregister_subdev(sd); Good spot. Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > v4l2_ctrl_handler_free(&info->hdl); > clk_disable_unprepare(info->clk); > #if defined(CONFIG_MEDIA_CONTROLLER) >
