Hi Jacopo,
On Wed, Nov 15, 2017 at 11:55 AM, Jacopo Mondi
<jacopo+renesas@xxxxxxxxxx> wrote:
> Add Capture Engine Unit (CEU) node to device tree.
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
Thanks for your patch!
> --- a/arch/arm/boot/dts/r7s72100.dtsi
> +++ b/arch/arm/boot/dts/r7s72100.dtsi
> @@ -136,8 +136,8 @@
> compatible = "renesas,r7s72100-mstp-clocks", "renesas,cpg-mstp-clocks";
> reg = <0xfcfe042c 4>;
> clocks = <&p0_clk>;
You forgot to add an entry to clocks.
The parent clock of the CEU module clock is b_clk.
> - clock-indices = <R7S72100_CLK_RTC>;
> - clock-output-names = "rtc";
> + clock-indices = <R7S72100_CLK_RTC R7S72100_CLK_CEU>;
> + clock-output-names = "rtc", "ceu";
Usually we follow the order from <dt-bindings/clock/r7s72100-clock.h>,
so CEU should come before RTC.
> @@ -666,4 +666,12 @@
> power-domains = <&cpg_clocks>;
> status = "disabled";
> };
> +
> + ceu: ceu@e8210000 {
> + reg = <0xe8210000 0x209c>;
> + compatible = "renesas,renesas-ceu";
> + interrupts = <GIC_SPI 332 IRQ_TYPE_LEVEL_HIGH>;
> + power-domains = <&cpg_clocks>;
if you describe the device to be part of the CPG clock domain, you should
provide a clocks property:
clocks = <&mstp6_clks R7S72100_CLK_CEU>;
> + status = "disabled";
> + };
> };
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
