Hi Rajmohan, My apologies for the late reply. On Sat, Nov 11, 2017 at 04:07:22AM +0000, Mani, Rajmohan wrote: > Hi Sakari, > > > -----Original Message----- > > From: Sakari Ailus [mailto:sakari.ailus@xxxxxx] > > Sent: Friday, October 20, 2017 2:30 AM > > To: Zhi, Yong <yong.zhi@xxxxxxxxx> > > Cc: linux-media@xxxxxxxxxxxxxxx; sakari.ailus@xxxxxxxxxxxxxxx; Zheng, Jian Xu > > <jian.xu.zheng@xxxxxxxxx>; Mani, Rajmohan <rajmohan.mani@xxxxxxxxx>; > > Toivonen, Tuukka <tuukka.toivonen@xxxxxxxxx>; Hu, Jerry W > > <jerry.w.hu@xxxxxxxxx> > > Subject: Re: [PATCH v4 04/12] intel-ipu3: Add user space ABI definitions > > > > Hi Yong, > > > > On Tue, Oct 17, 2017 at 10:54:49PM -0500, Yong Zhi wrote: ... > > > +struct ipu3_uapi_params { > > > + __u32 fourcc; /* V4L2_PIX_FMT_IPU3_PARAMS */ > > > + __u32 version; /* Must be 0x100 */ > > > > These were called padding1 and padding2 in the previous version. What > > happened? > > > > I'd just call them reserved, and maybe also make the use field the first > > member of the struct. > > > > These fields were repurposed after v3 of this patch series. Please see the user space code that uses these fields. > https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/master/hal/intel/psl/ipu3/workers/IPU3AicToFwEncoder.cpp They were fourcc and version in the beginning, and then replaced by padding1 and padding 2. Is there a particular reason for changing them back? -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
