Re: 'LITE-ON USB2.0 DVB-T Tune' driver crash with kernel 4.13 / ubuntu 17.10

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 12, 2017 at 09:38:47AM +0100, Laurent Caumont wrote:
> Hi Sean,
> 
> Thank you for the changes, It's better like this, I will test it.

Great, thanks. Please let us know if it works, then it can be included.

> Don't you think that a much better way would be to make the kalloc
> directly inside dvb_usb_generic_rw instead of changing each call of
> it? Are you sure there are no other mistake somewhere else ?

That would introduce an extra kmalloc and memcpy in that function, and
for many call sites that would be unnecesary, so it would be inefficient.


Sean



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux