Re: [PATCH 1/2] media: usb: uvc: remove duplicate & operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Laurent

Could you please review this patch?

Thanks, jaejoong

2017-10-20 16:25 GMT+09:00 Jaejoong Kim <climbbb.kim@xxxxxxxxx>:
> usb_endpoint_maxp() has an inline keyword and searches for bits[10:0]
> by & operation with 0x7ff. So, we can remove the duplicate & operation
> with 0x7ff.
>
> Signed-off-by: Jaejoong Kim <climbbb.kim@xxxxxxxxx>
> ---
>  drivers/media/usb/uvc/uvc_video.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
> index fb86d6a..f4ace63 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -1469,13 +1469,13 @@ static unsigned int uvc_endpoint_max_bpi(struct usb_device *dev,
>         case USB_SPEED_HIGH:
>                 psize = usb_endpoint_maxp(&ep->desc);
>                 mult = usb_endpoint_maxp_mult(&ep->desc);
> -               return (psize & 0x07ff) * mult;
> +               return psize * mult;
>         case USB_SPEED_WIRELESS:
>                 psize = usb_endpoint_maxp(&ep->desc);
>                 return psize;
>         default:
>                 psize = usb_endpoint_maxp(&ep->desc);
> -               return psize & 0x07ff;
> +               return psize;
>         }
>  }
>
> --
> 2.7.4
>



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux