Hi Yong,
On Mon, Oct 23, 2017 at 10:41:57PM +0000, Zhi, Yong wrote:
> > > + default:
> > > + return -EINVAL;
> > > + }
> > > +
> > > + return 0;
> > > +}
> > > +
> > > +static int ipu3_try_fmt(struct file *file, void *fh, struct
> > > +v4l2_format *f) {
> > > + struct v4l2_pix_format_mplane *pixm = &f->fmt.pix_mp;
> > > + const struct ipu3_fmt *fmt;
> > > +
> > > + if (f->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)
> > > + fmt = find_format(f, M2M_CAPTURE);
> > > + else if (f->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE)
> > > + fmt = find_format(f, M2M_OUTPUT);
> > > + else
> > > + return -EINVAL;
> > > +
> > > + pixm->pixelformat = fmt->fourcc;
> > > +
> > > + memset(pixm->plane_fmt[0].reserved, 0,
> > > + sizeof(pixm->plane_fmt[0].reserved));
> >
> > No need for the memset here, the framework handles this.
> >
> > Are there limits on the image size?
> >
>
> The memset is added to fix v4l2-compliance failure here.
Oops. Indeed, this is about the plane format. Please ignore the comment.
--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx
