Hi Mauro, Thank you for the patch. On Wednesday, 1 November 2017 23:05:45 EET Mauro Carvalho Chehab wrote: > Smatch reports this warning: > drivers/media/v4l2-core/v4l2-async.c:597 v4l2_async_register_subdev() > error: uninitialized symbol 'ret'. > > However, there's nothing wrong there. So, just shut up the > warning. Nothing wrong, really ? ret does seem to be used uninitialized when the function returns at the very last line. > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> > --- > drivers/media/v4l2-core/v4l2-async.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/v4l2-core/v4l2-async.c > b/drivers/media/v4l2-core/v4l2-async.c index 49f7eccc76db..5bc861c4ae5c > 100644 > --- a/drivers/media/v4l2-core/v4l2-async.c > +++ b/drivers/media/v4l2-core/v4l2-async.c > @@ -532,7 +532,7 @@ int v4l2_async_register_subdev(struct v4l2_subdev *sd) > { > struct v4l2_async_notifier *subdev_notifier; > struct v4l2_async_notifier *notifier; > - int ret; > + int uninitialized_var(ret); > > /* > * No reference taken. The reference is held by the device -- Regards, Laurent Pinchart