Hi, Sakari, Thanks for the feedback. > -----Original Message----- > From: Sakari Ailus [mailto:sakari.ailus@xxxxxx] > Sent: Tuesday, October 10, 2017 1:33 AM > To: Zhi, Yong <yong.zhi@xxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx; sakari.ailus@xxxxxxxxxxxxxxx; > hans.verkuil@xxxxxxxxx; Zheng, Jian Xu <jian.xu.zheng@xxxxxxxxx>; > tfiga@xxxxxxxxxxxx; Mani, Rajmohan <rajmohan.mani@xxxxxxxxx>; > Toivonen, Tuukka <tuukka.toivonen@xxxxxxxxx>; Yang, Hyungwoo > <hyungwoo.yang@xxxxxxxxx>; Vijaykumar, Ramya > <ramya.vijaykumar@xxxxxxxxx>; Rapolu, Chiranjeevi > <chiranjeevi.rapolu@xxxxxxxxx> > Subject: Re: [PATCH v5 2/3] doc-rst: add IPU3 raw10 bayer pixel format > definitions > > Hi Yong, > > On Fri, Oct 06, 2017 at 06:39:00PM -0500, Yong Zhi wrote: > > The formats added by this patch are: > > > > V4L2_PIX_FMT_IPU3_SBGGR10 > > V4L2_PIX_FMT_IPU3_SGBRG10 > > V4L2_PIX_FMT_IPU3_SGRBG10 > > V4L2_PIX_FMT_IPU3_SRGGB10 > > > > Signed-off-by: Yong Zhi <yong.zhi@xxxxxxxxx> > > Signed-off-by: Hyungwoo Yang <hyungwoo.yang@xxxxxxxxx> > > --- > > Documentation/media/uapi/v4l/pixfmt-rgb.rst | 1 + > > .../media/uapi/v4l/pixfmt-srggb10-ipu3.rst | 166 > +++++++++++++++++++++ > > 2 files changed, 167 insertions(+) > > create mode 100644 > > Documentation/media/uapi/v4l/pixfmt-srggb10-ipu3.rst > > > > diff --git a/Documentation/media/uapi/v4l/pixfmt-rgb.rst > > b/Documentation/media/uapi/v4l/pixfmt-rgb.rst > > index 4cc27195dc79..cf2ef7df9616 100644 > > --- a/Documentation/media/uapi/v4l/pixfmt-rgb.rst > > +++ b/Documentation/media/uapi/v4l/pixfmt-rgb.rst > > @@ -16,6 +16,7 @@ RGB Formats > > pixfmt-srggb10p > > pixfmt-srggb10alaw8 > > pixfmt-srggb10dpcm8 > > + pixfmt-srggb10-ipu3 > > pixfmt-srggb12 > > pixfmt-srggb12p > > pixfmt-srggb16 > > diff --git a/Documentation/media/uapi/v4l/pixfmt-srggb10-ipu3.rst > > b/Documentation/media/uapi/v4l/pixfmt-srggb10-ipu3.rst > > new file mode 100644 > > index 000000000000..50292186a8b4 > > --- /dev/null > > +++ b/Documentation/media/uapi/v4l/pixfmt-srggb10-ipu3.rst > > @@ -0,0 +1,166 @@ > > +.. -*- coding: utf-8; mode: rst -*- > > + > > +.. _V4L2_PIX_FMT_IPU3_SBGGR10: > > +.. _V4L2_PIX_FMT_IPU3_SGBRG10: > > +.. _V4L2_PIX_FMT_IPU3_SGRBG10: > > +.. _V4L2_PIX_FMT_IPU3_SRGGB10: > > + > > > +*************************************************************** > ****** > > > +*************************************************************** > ****** > > +**** > > +V4L2_PIX_FMT_IPU3_SBGGR10 ('ip3b'), V4L2_PIX_FMT_IPU3_SGBRG10 > > +('ip3g'), V4L2_PIX_FMT_IPU3_SGRBG10 ('ip3G'), > > +V4L2_PIX_FMT_IPU3_SRGGB10 ('ip3r') > > > +*************************************************************** > ****** > > > +*************************************************************** > ****** > > +**** > > + > > +10-bit Bayer formats > > + > > +Description > > +=========== > > + > > +These four pixel formats are used by Intel IPU3 driver, they are raw > > +sRGB / Bayer formats with 10 bits per sample with every 25 pixels > > +packed to 32 bytes leaving 6 most significant bits padding in the last byte. > > +The format is little endian. > > + > > +In other respects this format is similar to :ref:`V4L2-PIX-FMT-SRGGB10`. > > You could add: > > Below is an example of a small image in V4L2_PIX_FMT_IPU3_SBGGR10 > format. > Ack. > > + > > +**Byte Order.** > > +Each cell is one byte. > > + > > +.. raw:: latex > > + > > + \newline\newline\begin{adjustbox}{width=\columnwidth} > > + > > +.. tabularcolumns:: > > > +|p{1.3cm}|p{1.0cm}|p{10.9cm}|p{10.9cm}|p{10.9cm}|p{1.0cm}|p{1.0cm}|p > { > > > +10.9cm}|p{10.9cm}|p{10.9cm}|p{1.0cm}|p{1.0cm}|p{10.9cm}|p{10.9cm}|p{ > 1 > > > +0.9cm}|p{1.0cm}|p{1.0cm}|p{10.9cm}|p{10.9cm}|p{10.9cm}|p{1.0cm}|p{1. > 0 > > > +cm}|p{10.9cm}|p{10.9cm}|p{10.9cm}|p{1.0cm}|p{1.0cm}|p{10.9cm}|p{10.9 > c > > +m}|p{10.9cm}|p{1.0cm}|p{1.0cm}|p{10.9cm}| > > The width of this table is over one metre. Could you use fewer columns in it, > say, four or eight? > Sure, will do four columns in next update. (snip) > > -- > Kind regards, > > Sakari Ailus > e-mail: sakari.ailus@xxxxxx
