Hi Pierre,
Am Freitag, 20. Oktober 2017, 21:18:38 CEST schrieb Pierre-Hugues Husson:
> The documentation already mentions "cec" optional clock, but
> currently the driver doesn't enable it.
>
> Changes:
> v2:
> - Separate ENOENT errors from others
> - Propagate other errors (especially -EPROBE_DEFER)
>
> Signed-off-by: Pierre-Hugues Husson <phh@xxxxxx>
> ---
it looks like you might be missing some important people in your recipient list.
get_maintainer.pl shows me:
- Archit Taneja <architt@xxxxxxxxxxxxxx> (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
- Andrzej Hajda <a.hajda@xxxxxxxxxxx> (maintainer:DRM DRIVERS FOR BRIDGE CHIPS)
- dri-devel@xxxxxxxxxxxxxxxxxxxxx (open list:DRM DRIVERS)
So these should definitly be included in your recipients, as they're the
ones that will apply your patch :-)
One further nit below.
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index bf14214fa464..b31fc95d5fef 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -138,6 +138,7 @@ struct dw_hdmi {
> struct device *dev;
> struct clk *isfr_clk;
> struct clk *iahb_clk;
> + struct clk *cec_clk;
> struct dw_hdmi_i2c *i2c;
>
> struct hdmi_data_info hdmi_data;
> @@ -2382,6 +2383,27 @@ __dw_hdmi_probe(struct platform_device *pdev,
> goto err_isfr;
> }
>
> + hdmi->cec_clk = devm_clk_get(hdmi->dev, "cec");
> + if (PTR_ERR(hdmi->cec_clk) == -ENOENT) {
> + hdmi->cec_clk = NULL;
> + } else if (IS_ERR(hdmi->cec_clk)) {
> + ret = PTR_ERR(hdmi->cec_clk);
> + if (ret != -EPROBE_DEFER) {
> + dev_err(hdmi->dev, "Cannot get HDMI cec clock: %d\n",
> + ret);
> + }
braces around the single dev_err are not necessary.
Heiko
