Re: [PATCH v3 08/12] intel-ipu3: params: compute and program ccs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 20, 2017 at 02:51:07PM +0000, Zhi, Yong wrote:
> > > +			/* flip table to for convolution reverse indexing */
> > > +			s64 coeff =  coeffs[coeffs_size -
> > > +						((tap * (coeffs_size / taps)) +
> > > +						phase) - 1];
> > > +			coeff *= mantissa;
> > > +			coeff /= input_width;
> > 
> > Please use do_div() so this will compile on 32-bit machines.
> > 
> 
> Thanks, above was implemented in v4.

Yeah, I noticed that later. I accidentally reviewed an older version. ;)

-- 
Sakari Ailus
e-mail: sakari.ailus@xxxxxx



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux