Hi Andy, Thanks for the patchset. On Wed, Sep 27, 2017 at 09:24:55PM +0300, Andy Shevchenko wrote: > The driver has been submitted with a limitation to few platforms and > sensors which it does support. Even though two sensor drivers have no > users neither on ACPI-enabled platforms, nor in current Linux kernel > code. Patches 1 and 2 removes those drivers for now. > > It seems new contributors follow cargo cult programming done by the > original driver developers. It's neither good for code, nor for > reviewing process. To avoid such issues in the future here are few clean > up patches, i.e. patches 3, 4, 6. 13. > > On top of this here are clean ups with regard to GPIO use. One may > consider this as an intermediate clean up. This part toughly related to > removal of unused sensor drivers in patches 1 and 2. > > Patch series has been partially compile tested. It would be nice to see > someone with hardware to confirm it doesn't break anything. Partially compile tested? :-) That sounds really reliable. ;) Considering the cleanups this set contains, and we need to move forward, reducing the number of extra drivers that are unverifiable anyway, I think the patchset is definitely worth merging. I've rebased this on the current atomisp branch, and I've pushed the result here: <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=atomisp-andy> Let me know if you see issues. The only manually resolved conflict was in the removal of the ap1302 driver. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx
