On Tue, Oct 17, 2017 at 08:10:15AM +1100, Tobin C. Harding wrote: > On Mon, Oct 16, 2017 at 02:34:48PM +0200, Hans de Goede wrote: > > diff --git a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c > > index 828fe5abd832..6671ebe4ecc9 100644 > > --- a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c > > +++ b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c > > @@ -29,6 +29,7 @@ struct gmin_subdev { > > struct v4l2_subdev *subdev; > > int clock_num; > > int clock_src; > > + bool clock_on; > > struct clk *pmc_clk; > > struct gpio_desc *gpio0; > > struct gpio_desc *gpio1; > > @@ -583,6 +584,9 @@ static int gmin_flisclk_ctrl(struct v4l2_subdev *subdev, int on) > > struct gmin_subdev *gs = find_gmin_subdev(subdev); > > struct i2c_client *client = v4l2_get_subdevdata(subdev); > > > > + if (gs->clock_on == !!on) > > + return 0; > > + > > if (on) { > > ret = clk_set_rate(gs->pmc_clk, gs->clock_src); > > Which tree [and branch] are you working off please? In the staging-next branch of Greg's staging > tree this function does not appear as it is in this patch. Media tree master. <URL:https://git.linuxtv.org/media_tree.git/log/> -- Sakari Ailus e-mail: sakari.ailus@xxxxxx