On Wed, Oct 11, 2017 at 01:36:39PM +0000, Benoit Parrot wrote: > > > > + /* > > > > + * We use the stream ID there, but it's wrong. > > > > + * > > > > + * A stream could very well send a data type that is > > > > + * not equal to its stream ID. We need to find a > > > > + * proper way to address it. > > > > + */ > > > > > > I don't quite get the above comment, from the code below it looks like > > > you are using the current fmt as a source to provide the correct DT. > > > Am I missing soemthing? > > > > Yes, so far the datatype is inferred from the format set. Is there > > anything wrong with that? > > No, nothing wrong with that behavior it just doesn't not match the comment > above, where it is says that the DT is set to the stream ID... As explained in the cover letter, you actually have two datatypes, the input one that is in the 0-8 range, which is then mapped through that register to a MIPI-CSI2 datatype. The comment refers to the input datatype, not the CSI's. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature
