Hi Mauro, Thanks for the patch. On Mon, Oct 09, 2017 at 07:19:08AM -0300, Mauro Carvalho Chehab wrote: > There are two ancillary functions at v4l2-flash-led-class.h > that aren't documented. > > Document them. > > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> > --- > include/media/v4l2-flash-led-class.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/media/v4l2-flash-led-class.h b/include/media/v4l2-flash-led-class.h > index 5c1d50f78e12..39a5daa977aa 100644 > --- a/include/media/v4l2-flash-led-class.h > +++ b/include/media/v4l2-flash-led-class.h > @@ -91,12 +91,24 @@ struct v4l2_flash { > struct v4l2_ctrl **ctrls; > }; > > +/** > + * v4l2_subdev_to_v4l2_flash - Returns a &v4l2_flash from the v4l2_flash -> struct v4l2_flash ? Same below. With these, Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > + * &struct v4l2_subdev embedded on it. > + * > + * @sd: pointer to &struct v4l2_subdev > + */ > static inline struct v4l2_flash *v4l2_subdev_to_v4l2_flash( > struct v4l2_subdev *sd) > { > return container_of(sd, struct v4l2_flash, sd); > } > > +/** > + * v4l2_ctrl_to_v4l2_flash - Returns a &v4l2_flash from the > + * &struct v4l2_ctrl embedded on it. > + * > + * @c: pointer to &struct v4l2_ctrl > + */ > static inline struct v4l2_flash *v4l2_ctrl_to_v4l2_flash(struct v4l2_ctrl *c) > { > return container_of(c->handler, struct v4l2_flash, hdl); -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx