Sean Young <sean@xxxxxxxx> writes: > Hi Marc, > > Looks great, just some minor nitpicks. > > On Thu, Oct 05, 2017 at 04:54:11PM +0200, Marc Gonzalez wrote: >> Add a keymap for the Sigma Designs Vantage (dev board) remote control. >> >> Signed-off-by: Marc Gonzalez <marc_gonzalez@xxxxxxxxxxxxxxxx> >> --- >> drivers/media/rc/keymaps/Makefile | 1 + >> drivers/media/rc/keymaps/rc-tango.c | 84 +++++++++++++++++++++++++++++++++++++ >> drivers/media/rc/tango-ir.c | 2 +- >> include/media/rc-map.h | 1 + >> 4 files changed, 87 insertions(+), 1 deletion(-) >> create mode 100644 drivers/media/rc/keymaps/rc-tango.c >> >> diff --git a/drivers/media/rc/keymaps/Makefile b/drivers/media/rc/keymaps/Makefile >> index af6496d709fb..3c1e31321e21 100644 >> --- a/drivers/media/rc/keymaps/Makefile >> +++ b/drivers/media/rc/keymaps/Makefile >> @@ -88,6 +88,7 @@ obj-$(CONFIG_RC_MAP) += rc-adstech-dvb-t-pci.o \ >> rc-reddo.o \ >> rc-snapstream-firefly.o \ >> rc-streamzap.o \ >> + rc-tango.o \ >> rc-tbs-nec.o \ >> rc-technisat-ts35.o \ >> rc-technisat-usb2.o \ >> diff --git a/drivers/media/rc/keymaps/rc-tango.c b/drivers/media/rc/keymaps/rc-tango.c >> new file mode 100644 >> index 000000000000..c76651695959 >> --- /dev/null >> +++ b/drivers/media/rc/keymaps/rc-tango.c >> @@ -0,0 +1,84 @@ > > I think you need a header with copyright statement and GPL version(s). Is this even copyrightable? -- Måns Rullgård
