Hi Kieran, > Rather than forward declaring the function ... Could you put the function higher > in the module please? Will do. Patch will come as a reply shortly. >>> + if (data == NULL) >>> + return -ENOMEM; >> >> This will set the callers 'flags' to -ENOMEM ? Is that desired? >> >> Of course removing the kmalloc will fix that anyway ... > Perhaps we have to return an empty flags here, which is what we will return if > the uvc_query_ctrl() fails anyway. I wanted to keep the changes to a minimum. So I didn't touch the return values. Are there any checks done for -ENOMEM et al? I didn't see any. -Edgar
