Em Sun, 25 Jun 2017 14:31:50 +0200
David Härdeman <david@xxxxxxxxxxx> escreveu:
> lirc_zilog uses a chunk_size of 2 and ir-lirc-codec uses sizeof(int).
>
> Therefore, using stack memory should be perfectly fine.
>
> Signed-off-by: David Härdeman <david@xxxxxxxxxxx>
> ---
> drivers/media/rc/lirc_dev.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
> index 1773a2934484..92048d945ba7 100644
> --- a/drivers/media/rc/lirc_dev.c
> +++ b/drivers/media/rc/lirc_dev.c
> @@ -376,7 +376,7 @@ ssize_t lirc_dev_fop_read(struct file *file,
> loff_t *ppos)
> {
> struct irctl *ir = file->private_data;
> - unsigned char *buf;
> + unsigned char buf[ir->buf->chunk_size];
No. We don't do dynamic buffer allocation on stak at the Kernel,
as this could cause the Linux stack to overflow without notice.
This should also generate alerts on static code analyzers like
sparse.
I'll drop this patch from the series.
Thanks,
Mauro
