Re: v4l: Use the video_drvdata function in drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 18 November 2009 08:01:48 Hans Verkuil wrote:
> On Wednesday 18 November 2009 01:38:48 Laurent Pinchart wrote:
> > Fix all device drivers to use the video_drvdata function instead of
> > maintaining a local list of minor to private data mappings. Call
> > video_set_drvdata to register the driver private pointer when not
> > already done.
> >
> > Where applicable, the local list of mappings is completely removed when
> > it becomes unused.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> 
> Very nice cleanup!

Thank you.

> But you need to check the lock_kernel calls carefully, I think one is now
> unbalanced:

[snip]

Thanks for catching this. I tried to be quite careful but this one slipped in. 
I was planning to recheck all the patches for this kind of issue, so now is a 
good time to do so :-)

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux