Re: [PATCH 2/3] radio-si470x: move some file operations to common file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 18 November 2009 07:42:41 Hans Verkuil wrote:
> On Wednesday 18 November 2009 07:21:30 Joonyoung Shim wrote:
> > The read and poll file operations of the si470x usb driver can be used
> > also equally on the si470x i2c driver, so they go to the common file.
> > 
> > Signed-off-by: Joonyoung Shim <jy0922.shim@xxxxxxxxxxx>
> 
> Why on earth is the i2c driver registering a radio device? If I understand
> it correctly the usb and i2c driver are both registering a radio device
> where there should be only one!
> 
> i2c drivers should in general never register video devices. That's the task
> of the bridge driver.
> 
> Does anyone know why the current driver behaves like this? I think that should
> be fixed first.
> 
> Regards,
> 
> 	Hans
> 

It's too early in the morning. Forget what I said :-)

The two drivers are independent, the usb driver doesn't depend on the i2c
driver. Now it makes a lot more sense.

Regards,

	Hans

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux