On Thu, Sep 21, 2017 at 06:20:28PM +0200, Marc Gonzalez wrote: > On 21/09/2017 17:57, Sean Young wrote: > > > On Thu, Sep 21, 2017 at 04:49:53PM +0200, Marc Gonzalez wrote: > > > >> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. > >> > >> Signed-off-by: Marc Gonzalez <marc_gonzalez@xxxxxxxxxxxxxxxx> > > > > Missing signed-off-by. > > I am aware of that. Hopefully, at some point, Mans will add his. > I have no control over this, unless I rewrite the driver from > scratch. > > > Your patch still gives numerous checkpatch warnings, please run it > > preferaby with --strict. > > Some checkpatch warnings are silly, such as unconditionally mandating > 4 lines for a Kconfig help message. Do you consider it mandatory to > address all warnings, whatever they are? Yes, they're mandatory. The Kconfig could state what the module name is, which is helpful. See: https://www.kernel.org/doc/html/v4.12/process/submitting-patches.html https://www.kernel.org/doc/html/v4.12/process/coding-style.html Sean
