Re: [PATCH] scripts: kernel-doc: fix nexted handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Jon,
> 
> While documenting some DVB demux  headers, I noticed the above bug.
> 
> scripts/kernel-doc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
> index 9d3eafea58f0..15f934a23d1d 100755
> --- a/scripts/kernel-doc
> +++ b/scripts/kernel-doc
> @@ -2173,7 +2173,7 @@ sub dump_struct($$) {
> 	my $members = $3;
> 
> 	# ignore embedded structs or unions
> -	$members =~ s/({.*})//g;
> +	$members =~ s/({[^\}]*})//g;
> 	$nested = $1;
> 
> 	# ignore members marked private:

Hi Mauro,

I tested this patch. Feel free to add my

 Tested-by: Markus Heiser <markus.heiser@xxxxxxxxxxx>

FYI: I also migrated the patch to my python kernel-doc parser:

   https://github.com/return42/linuxdoc/commit/5dbb93f

And here is the impact of this patch on the whole sources:

   https://github.com/return42/sphkerneldoc/commit/7be0fa85

In the last link, you see that your patch is a great improvement / Thanks!!

-- Markus --




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux