From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> Date: Wed, 20 Sep 2017 20:46:11 +0200 * The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix an affected source code place. * Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> --- drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c b/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c index 38394c9ecc67..fef3c8554e91 100644 --- a/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c +++ b/drivers/media/usb/ttusb-budget/dvb-ttusb-budget.c @@ -1657,7 +1657,8 @@ static int ttusb_probe(struct usb_interface *intf, const struct usb_device_id *i if (intf->altsetting->desc.bInterfaceNumber != 1) return -ENODEV; - if (!(ttusb = kzalloc(sizeof(struct ttusb), GFP_KERNEL))) + ttusb = kzalloc(sizeof(*ttusb), GFP_KERNEL); + if (!ttusb) return -ENOMEM; ttusb->dev = udev; @@ -1692,7 +1693,7 @@ static int ttusb_probe(struct usb_interface *intf, const struct usb_device_id *i ttusb->adapter.priv = ttusb; /* i2c */ - memset(&ttusb->i2c_adap, 0, sizeof(struct i2c_adapter)); + memset(&ttusb->i2c_adap, 0, sizeof(ttusb->i2c_adap)); strcpy(ttusb->i2c_adap.name, "TTUSB DEC"); i2c_set_adapdata(&ttusb->i2c_adap, ttusb); -- 2.14.1
