Hi Sakari, On Tuesday, 19 September 2017 15:20:34 EEST Sakari Ailus wrote: > On Tue, Sep 19, 2017 at 03:08:25PM +0300, Laurent Pinchart wrote: > > On Friday, 15 September 2017 17:17:20 EEST Sakari Ailus wrote: > >> Parse async sub-devices by using > >> v4l2_subdev_fwnode_reference_parse_sensor_common(). > >> > >> These types devices aren't directly related to the sensor, but are > >> nevertheless handled by the smiapp driver due to the relationship of > >> these component to the main part of the camera module --- the sensor. > >> > >> This does not yet address providing the user space with information on > >> how to associate the sensor or lens devices but the kernel now has the > >> necessary information to do that. > >> > >> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > >> Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > >> Acked-by: Pavel Machek <pavel@xxxxxx> > > > > Something is bothering me here, not so much in the contents of the patch > > itself than in its nature. There are four patches in this series that add > > support for flash and lens devices to the smiapp, et8ek8, ov5670 and > > ov13858 drivers. We have way more sensor drivers than that, and I don't > > really want to patch them all to support flash and lens. I believe a less > > intrusive approach, more focussed on the V4L2 core, is needed. > > You could move this to the framework, yes. Nothing prevents that. Perhaps a > flag telling the framework whether this should be done? Just being > opportunistic might work as well. How is would be done is another matter which I haven't thought about yet :-) My point is that I don't think converting all drivers is a good idea, you should aim for an implementation in the core. > >> --- > >> > >> drivers/media/i2c/smiapp/smiapp-core.c | 38 ++++++++++++++++++++------- > >> drivers/media/i2c/smiapp/smiapp.h | 4 +++- > >> 2 files changed, 33 insertions(+), 9 deletions(-) -- Regards, Laurent Pinchart
