Marc Gonzalez <marc_gonzalez@xxxxxxxxxxxxxxxx> writes: > On 18/09/2017 17:33, Måns Rullgård wrote: > >> What have you changed compared to my original code? > > I forgot to mention one change you may not approve of, so we should > probably discuss it. > > Your driver supported an optional DT property "linux,rc-map-name" > to override the RC_MAP_EMPTY map. Since the IR decoder supports > multiple protocols, I found it odd to specify a scancode map in > something as low-level as the device tree. > > I saw only one board using that property: > $ git grep "linux,rc-map-name" arch/ > arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts: linux,rc-map-name = "rc-geekbox"; > > So I removed support for "linux,rc-map-name" and used ir-keytable > to load a given map from user-space, depending on which RC I use. > > Mans, Sean, what do you think? The property is documented as common for IR receivers although only a few drivers seem to actually implement the feature. Since driver support is trivial, I see no reason to skip it. Presumably someone had a use for it, or it wouldn't have been added. -- Måns Rullgård
