Hi Laurent, On Tue, Sep 19, 2017 at 03:12:42PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Friday, 15 September 2017 17:17:14 EEST Sakari Ailus wrote: > > Camera flash drivers (and LEDs) are separate from the sensor devices in > > DT. In order to make an association between the two, provide the > > association information to the software. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > Acked-by: Rob Herring <robh@xxxxxxxxxx> > > Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > Acked-by: Pavel Machek <pavel@xxxxxx> > > --- > > Documentation/devicetree/bindings/media/video-interfaces.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt > > b/Documentation/devicetree/bindings/media/video-interfaces.txt index > > 852041a7480c..fdba30479b47 100644 > > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > > @@ -67,6 +67,14 @@ are required in a relevant parent node: > > identifier, should be 1. > > - #size-cells : should be zero. > > > > + > > +Optional properties > > +------------------- > > + > > +- flash-leds: An array of phandles, each referring to a flash LED, a > > sub-node > > + of the LED driver device node. > > What happens with non-LED flash controllers ? We don't have any at the moment. The way the bindings are currently defined (LED references are to individual LEDs for instance) are specific to LED bindings. I'd rather not make assumptions for e.g. Xenon flash devices. Which might never appear: LED luminosity, efficiency and maximum current has been steadily increasing over the past years. -- Regards, Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
