On Sat, Sep 16, 2017 at 4:28 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>
> Document the bindings for the cec-gpio module for hardware where the
> CEC line and optionally the HPD line are connected to GPIO lines.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
Just to make things explicit:
> +Required properties:
> + - compatible: value must be "cec-gpio".
> + - cec-gpios: gpio that the CEC line is connected to.
Add "The line should be tagged as open drain."
> +Example for the Raspberry Pi 3 where the CEC line is connected to
> +pin 26 aka BCM7 aka CE1 on the GPIO pin header and the HPD line is
> +connected to pin 11 aka BCM17:
> +
#include <dt-bindings/gpio/gpio.h>
> +cec-gpio {
> + compatible = "cec-gpio";
> + cec-gpio = <&gpio 7 GPIO_OPEN_DRAIN>;
cec-gpios = <&gpio 7 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
> + hpd-gpio = <&gpio 17 GPIO_ACTIVE_HIGH>;
hpd-gpios = ..
With these fixups:
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Yours,
Linus Walleij
