Mauro, you are so speedy :)
2017-09-15 11:10 GMT+02:00 Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>:
> The stv6110 has a weird code that checks if get_property
> and set_property ioctls are defined. If they're, it initializes
> a "srate" var from properties cache. Otherwise, it sets to
> 15MBaud, with won't make any sense.
>
> Thankfully, it seems that someone already noticed, as the
> "srate" is not used anywhere!
Hehe! "Someone else" :)
>
> So, get rid of that really weird dead code logic.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>
Reported-by: Honza Petrous <jpetrous@xxxxxxxxx>
> ---
> drivers/media/dvb-frontends/stv6110.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/media/dvb-frontends/stv6110.c b/drivers/media/dvb-frontends/stv6110.c
> index e4fd9c1b0560..2821f6da6764 100644
> --- a/drivers/media/dvb-frontends/stv6110.c
> +++ b/drivers/media/dvb-frontends/stv6110.c
> @@ -262,7 +262,6 @@ static int stv6110_set_frequency(struct dvb_frontend *fe, u32 frequency)
> u8 ret = 0x04;
> u32 divider, ref, p, presc, i, result_freq, vco_freq;
> s32 p_calc, p_calc_opt = 1000, r_div, r_div_opt = 0, p_val;
> - s32 srate;
>
> dprintk("%s, freq=%d kHz, mclk=%d Hz\n", __func__,
> frequency, priv->mclk);
> @@ -273,13 +272,6 @@ static int stv6110_set_frequency(struct dvb_frontend *fe, u32 frequency)
> ((((priv->mclk / 1000000) - 16) & 0x1f) << 3);
>
> /* BB_GAIN = db/2 */
> - if (fe->ops.set_property && fe->ops.get_property) {
> - srate = c->symbol_rate;
> - dprintk("%s: Get Frontend parameters: srate=%d\n",
> - __func__, srate);
> - } else
> - srate = 15000000;
> -
> priv->regs[RSTV6110_CTRL2] &= ~0x0f;
> priv->regs[RSTV6110_CTRL2] |= (priv->gain & 0x0f);
>
> --
> 2.13.5
>
Don't be offended, I simply smiled on the therm "someone else"
/Honza
