Re: [PATCH v4 4/4] [media] exynos-gsc: Add hardware rotation limits

[Hoegeun Kwon <hoegeun.kwon@xxxxxxxxxxx>]

On 09/13/2017 09:13 PM, Sylwester Nawrocki wrote:
> On 09/13/2017 01:41 PM, Hoegeun Kwon wrote:
> > @@ -1004,11 +1088,33 @@ static irqreturn_t gsc_irq_handler(int irq, 
> > void *priv)
> >       .num_clocks = 1,
> >   };
> >   +static struct gsc_driverdata gsc_v_5250_drvdata = {
> > +    .variant = {
> > +        [0] = &gsc_v_5250_variant,
> > +        [1] = &gsc_v_5250_variant,
> > +        [2] = &gsc_v_5250_variant,
> > +        [3] = &gsc_v_5250_variant,
> > +    },
> > +    .num_entities = 4,
> > +    .clk_names = { "gscl" },
> > +    .num_clocks = 1,
> > +};
> > +
> > +static struct gsc_driverdata gsc_v_5420_drvdata = {
> > +    .variant = {
> > +        [0] = &gsc_v_5420_variant,
> > +        [1] = &gsc_v_5420_variant,
> > +    },
> > +    .num_entities = 4,
>
> Shouldn't num_enities be 2 here? You don't need to resend, I can
> amend that when applying.


Yes, num_enities is 2.
Sorry I made a mistake.

Thanks Sylwester.

Best regards,
Hoegeun

> > +    .clk_names = { "gscl" },
> > +    .num_clocks = 1,
> > +};
> > +
>
> --
> Regards,
> Sylwester