On Wed, Sep 13, 2017 at 02:27:53PM +0530, Allen Pais wrote: > Signed-off-by: Allen Pais <allen.lkml@xxxxxxxxx> Sorry, the patch is right, but the commit is still totally messed up. bad: [PATCH v3] drivers/staging:[media]atomisp:use ARRAY_SIZE() instead of open coding. good: [PATCH v4] [media] atomisp: use ARRAY_SIZE() instead of open coding. Please, copy the "[media] atomisp: " prefix exactly as I wrote it. Then the commit message can say something like: The array_length() macro just duplicates ARRAY_SIZE() so we can delete it. > Signed-off-by: Allen Pais <allen.lkml@xxxxxxxxx> > --- ^^^ Then under the --- line put: v4: Update the commit message. regards, dan carpenter
