Re: [PATCH v12 06/26] v4l: fwnode: Support generic parsing of graph endpoints, per port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hans,

Thanks for the review.

On Wed, Sep 13, 2017 at 09:06:11AM +0200, Hans Verkuil wrote:
> On 09/13/2017 09:01 AM, Hans Verkuil wrote:
> > On 09/12/2017 03:41 PM, Sakari Ailus wrote:
> >> This is just like like v4l2_async_notifier_parse_fwnode_endpoints but it
> >> only parses endpoints on a single port. The behaviour is useful on devices
> >> that have both sinks and sources, in other words only some of these should
> >> be parsed.
> 
> I forgot to mention that I think the log message can be improved: it is not
> clear why you would only parse some of the ports for devices that have both
> sinks and sources. That should be explained better. And probably also in the
> header documentation.

I'll add both.

-- 
Sakari Ailus
e-mail: sakari.ailus@xxxxxx



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux