On Mon, Sep 11, 2017 at 01:17:46PM +0200, Pavel Machek wrote: > On Mon 2017-09-11 11:00:03, Sakari Ailus wrote: > > Add v4l2_fwnode_parse_reference_sensor_common for parsing common > > sensor properties that refer to adjacent devices such as flash or lens > > driver chips. > > > > As this is an association only, there's little a regular driver needs to > > know about these devices as such. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> > > --- > > drivers/media/v4l2-core/v4l2-fwnode.c | 35 +++++++++++++++++++++++++++++++++++ > > include/media/v4l2-fwnode.h | 13 +++++++++++++ > > 2 files changed, 48 insertions(+) > > > > > > +/** > > + * v4l2_fwnode_reference_parse_sensor_common - parse common references on > > + * sensors for async sub-devices > > + * @dev: the device node the properties of which are parsed for references > > + * @notifier: the async notifier where the async subdevs will be added > > + * > > + * Return: 0 on success > > + * -ENOMEM if memory allocation failed > > + * -EINVAL if property parsing failed > > + */ > > Returns: would sound more correct to me, but it seems kernel is split > on that. I think in V4L2 there are roughly as many of each instances. I'll keep it as it is. > > Acked-by: Pavel Machek <pavel@xxxxxx> Thanks! -- Sakari Ailus e-mail: sakari.ailus@xxxxxx