On Tuesday 10 November 2009 20:21:44 Pete Eberlein wrote: > From: Pete Eberlein <pete@xxxxxxxxxxxx> > > Convert the go7007 driver to v4l2 subdev interface, using v4l2 i2c > subdev functions instead of i2c functions directly. The v4l2 ioctl ops > functions call subdev ops instead of i2c commands. > > Priority: normal > > Signed-off-by: Pete Eberlein <pete@xxxxxxxxxxxx> Signed-off-by: Hans Verkuil <hverkuil@xxxxxxxxx> Again, nice work! It's in much better shape now. When all this is in we need to take a good look at this and see what needs to be done to move this driver out of staging. One thing that needs to be fixed before that can happen is that I noticed the use of lock_kernel in s2250-loader.c: this should be done differently. The BKL is slowly being removed throughout the kernel so it should be removed here as well. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html