Hi all,
Thanks Thomas for the patch and sorry for delay, tested OK on my side
with STM32F429I-EVAL board running no-MMU STM32F429 chip.
Tested-by: Hugues Fruchet <hugues.fruchet@xxxxxx>
On 09/02/2017 03:29 PM, Thomas Petazzoni wrote:
> Hello,
>
> On Wed, 23 Aug 2017 13:06:13 +0200, Hans Verkuil wrote:
>> On 08/21/17 23:02, Thomas Petazzoni wrote:
>>> In commit 2e604dfbcd09b93f0808cedb2a0b324c5569a599 ("configure.ac: add
>>> --disable-libv4l option"), an option --disable-libv4l was added. As
>>> part of this, libv4l is no longer built at all in static linking
>>> configurations, just because libv4l uses dlopen() for plugin support.
>>>
>>> However, plugin support is only a side feature of libv4l, and one may
>>> need to use libv4l in static configurations, just without plugin
>>> support.
>>>
>>> Therefore, this commit:
>>>
>>> - Essentially reverts 2e604dfbcd09b93f0808cedb2a0b324c5569a599, so
>>> that libv4l can be built in static linking configurations again.
>>>
>>> - Adjusts the compilation of libv4l2 so that the plugin support is
>>> not compiled in when dlopen() in static linking configuration
>>> (dlopen is not available).
>>>
>>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>
>>> ---
>>> NOTE: this was only build-time tested, not runtime tested.
>>
>> Hugues, can you test this to make sure this still does what you need?
>>
>> It looks good to me, but I'd like to make sure it works for you as well
>> before committing this.
>
> Thanks for your feedback. Unfortunately, Hugues has not answered. What
> can we do ?
>
> Thanks,
>
> Thomas
>
