Hi Andreas, Em Sat, 14 Nov 2009 02:27:11 +0400 Manu Abraham <abraham.manu@xxxxxxxxx> escreveu: > Mauro, > > Please pull from http://jusst.de/hg/v4l-dvb for the following Instead of commenting patches like this: This patch fixes STR and SNR calculation and normalizes the value into the 0..0xFFFF range. From: Andreas Regel <andreas.regel@xxxxxx> Signed-off-by: Andreas Regel <andreas.regel@xxxxxx> Signed-off-by: Manu Abraham <manu@xxxxxxxxxxx> Next time, please take some time to check the proper way to add a patch description. There are some good texts at kernel Documentation/ directory. Basically: 1) it should not contain "this patch is..."; 2) the better is to start a patch with the name of the driver where it applies; 3) the first line is a summary of the patch. Ideally should be lower than 74 bytes; 4) you should explain why and what the patch does at the description. So, except for really trivial patches, please add a few lines at the patch description to better provide us an understanding on what the patch is doing. For this time, if all patches are ok (I haven't reviewed them yet), I'll fix the comments on my -git tree. Next time, please try to improve them. Thanks, Mauro Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
