Re: I found I bug in tvtime, where do I report it?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 13, 2009 at 9:43 AM, Magnus Alm <magnus.alm@xxxxxxxxx> wrote:
> Hi!
>
> If this is the right place, I can as well try to describe it now.
> (And I hope I makes sense.)
>
> The bug is about the "Enable/Disable signal detection".
>
> As it is now in  videoinput.c:
>
> int videoinput_check_for_signal( videoinput_t *vidin, int check_freq_present )
> {
>    if(  videoinput_freq_present( vidin ) || !check_freq_present ) {
>        switch( vidin->cur_tuner_state ) {
>        case TUNER_STATE_NO_SIGNAL:
>
>
> Should be:
>
> int videoinput_check_for_signal( videoinput_t *vidin, int check_freq_present )
> {
>    if( !check_freq_present || videoinput_freq_present( vidin )) {
>        switch( vidin->cur_tuner_state ) {
>        case TUNER_STATE_NO_SIGNAL:
>
> So just switch place for "videoinput_freq_present( vidin )" and
> "!check_freq_present" so it actually cares if you disable signal
> detection.
>
> With this change, disabling signal detection will remove the frame
> drops I have in tvtime.
>
>
> Cheers, have a nice weekend.
> Magnus Alm

>From a maintainership standpoint, tvtime is effectively dead.  I've
been planning on setting up a new hg tree over at
http://kernellabs.com/hg since I have some patches I want to get in
there too.  I can add yours to the series.

Cheers,

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux