Hans Verkuil wrote:
Hi Sakari, Thanks for the patch, but it is not complete. Most importantly the V4L2_BUF_TYPE_LAST define in v4l2-compliance.h isn't updated to V4L2_BUF_TYPE_META_OUTPUT. It's best to just do a 'git grep META_CAPTURE' in v4l-utils and check each place it is used whether META_OUTPUT support should also be added.
That's what I did but I somehow missed META_OUTPUT in v4l2-compliance.h. I'll update the set, but I don't expect this to be merged until the kernel support for metadata output goes in with Yong's ipu3 patchset.
Note for v4l2-ctl-meta.cpp: interestingly the usage help for meta formats already includes support for meta output, but no where else in v4l2-ctl is there meta output support. It appears to be unintentional that this was committed.
Seems so. This set is (so far) only adding support for v4l2-compliance. -- Sakari Ailus sakari.ailus@xxxxxxxxxxxxxxx
