On 17/08/17 20:50, Jemma Denson wrote:
On 16/08/17 10:42, Mauro Carvalho Chehab wrote:
I've just tested both your v2 patch and changes I'm suggesting above; both work
fine on my setup. Do you want me to send a v3?
Yeah, sure! I'm currently in travel, returning only on Friday, and I don't
have the hardware to test. So, if you can send it, I'd appreciate :-)
Cheers,
Mauro
Ok, just sent. The if statements ended up being a bit complicated, but I added checking
if the DCL bit was being overridden (it is by several cards under cx88), only pausing
for a second if DCL was in use as the datasheet suggested that's only done in that mode,
and also skipped checking overflow if the device was set to off.
The latter should cover overflow somehow being picked up during attach and causing the
attach to fail. Unlikely to happen but we shouldn't fail on what could be a transient
issue.
Sorry, time for a v4! I wasn't happy with adding a permanent 200ms pause so I've reverted
that back to how you had it before. The pause before re-enabling dcl is only really needed
if it needs time to settle down and so reverting back to always doing a 1000ms on overload
should cover it.
Jemma.
