Hi Laurent, Thanks for your review, On 16/08/17 22:53, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > How about > > if (WARN_ONCE(dlb->num_entries >= dlb->max_entries, > "DLB size exceeded (max %u)", dlb->max_entries)) > return; > > (WARN_ONCE contains the unlikely() already) > > I'm not fussed either way, That does seem cleaner. Updated ready for any repost. Thanks -- Kieran