Hi Hans, On Fri, Jul 28, 2017 at 10:53:35AM +0200, Hans Verkuil wrote: > Hi Sakari, > > Is the lens-focus phandle specific to voice-coil controllers? What about I think it's not important. Right now the information is used for making the association only. > motor-controlled focus systems? What when there are multiple motors? E.g. > one for the focus, one for the iris control (yes, we have that). I'd add another property for this purpose. > > What if you have two sensors (stereoscopic) controlled by one motor? You can refer to the same controller from both, I don't see a problem with that. The software would need to support that though, I think changes to the async framework would be needed. > > Just trying to understand this from a bigger perspective. Specifically > how this will scale when more of these supporting devices as added. > > Regards, > > Hans > > On 07/18/2017 09:03 PM, Sakari Ailus wrote: > > The lens-focus property contains a phandle to the lens voice coil driver > > that is associated to the sensor; typically both are contained in the same > > camera module. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > Acked-by: Pavel Machek <pavel@xxxxxx> > > Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx> > > Acked-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/media/video-interfaces.txt | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt > > index 9723f7e1c7db..a18d9b2d309f 100644 > > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt > > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt > > @@ -74,6 +74,8 @@ Optional properties > > - flash: phandle referring to the flash driver chip. A flash driver may > > have multiple flashes connected to it. > > > > +- lens-focus: A phandle to the node of the focus lens controller. > > + > > > > Optional endpoint properties > > ---------------------------- > > > -- Sakari Ailus e-mail: sakari.ailus@xxxxxx
