On Tuesday 10 November 2009 19:12:13 Santiago Nunez-Corrales wrote: > Hans, > > > Thanks for all your patient and detailed reviews. I've addressed most of > the comments. There is one thing though that seems odd but is there due > to a good reason. The devices requires to be turned off and on again > during the s_stream function, in which it 'forgets' its previous state > and therefore register values have to be kept in memory and set back for > initialization purposes. Hmm. It's still pretty ugly. Wouldn't it be more elegant to record this state at a higher level? E.g. instead of restoring gain registers you would store the current gain value in the state struct and just set the gain again. Ditto for things like the output standard, etc. Another question is: why does it need to be reset? That's rather peculiar. Are there powersaving considerations? Is this normal behavior for this device? I can't imagine that this is how the tvp7002 designers expected it to be used, so I get the feeling that what you are doing is more a kludge to hammer the driver into the v4l2_subdev API. Can you look at this some more? I have downloaded the tvp7002 datasheet, so you can also point me to the relevant sections/register descriptions of the datasheet. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG Telecom -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
